Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add simple CI to run unit tests/coverage checks for pull requests and publish #24

Merged
merged 3 commits into from
Feb 26, 2023

Conversation

KeranYang
Copy link
Member

@KeranYang KeranYang commented Feb 26, 2023

Closes #14

Also increase unit test coverage ratio limit from 70% to 75%. Thank you @yhl25 for creating high coverage commits, which raised our overall coverage by 5%. We might not require a 100% percentage but my goal is to make it at least 80%.

The change was tested on my branch KeranYang#3, where I mimicked a coverage failure and verified the CI workflow failed.

.
Signed-off-by: Keran Yang <[email protected]>
.
Signed-off-by: Keran Yang <[email protected]>
@KeranYang KeranYang merged commit f6eeb2e into numaproj:main Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI
2 participants